Merged
Conversation
I use to try and keep the window alway the same size when reaching the beginning and end of the scroll view, which in practices seems right. However with the more advanced centering logic of files and diffs, this can create situations where the bottom isn't fully rendered. It's unclear if this will fix the bug that conductor was seeing, but it's something.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small bug that can occur with windowing logic when reaching the bottom of a file.
Basically the repro for this bug is hard to trigger but for me it was simply showing a diff in the demo app based on the fileNew.txt, that had no previous content, then scroll to the bottom and you'd see some lines that didn't render