Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
deleted the
amadeus/hunk-separator-customization-improvements
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the hunk separator layout CSS so that internal elements size themselves relative to the separator’s own height, making separator height customization simpler and avoiding the need to update multiple nested rules.
Changes:
- Switched several separator sub-elements from fixed
32pxheights toheight: 100%so they inherit the outer separator height. - Updated expand button sizing to stretch with the separator instead of relying on fixed heights.
- Changed the multi-button grid rows from
16px 16pxto proportional50% 50%to scale with separator height.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorta had the epiphany today when debugging opencode -- we should make it easier for devs to customize the height of hunk separators without requiring a ton of nested CSS. So basically i tweaked the layout stuff so if you just specify a new height for the
[data-separator]element, all the rest of the CSS should adapt to it.