Skip to content

Conversation

@tsavo-at-pieces
Copy link

Summary

This pull request updates the SDK constraints in pubspec.yaml to support newer Dart versions and introduces workspace resolution for better dependency management within a monorepo setup. These changes ensure compatibility with the latest Flutter environment and streamline development workflows.

Changes

  • Update environment.sdk constraint to >=3.6.0 <4.0.0 in pubspec.yaml.
  • Add resolution: workspace to pubspec.yaml to enable workspace dependency resolution.

- Update Dart SDK constraint to `>=3.6.0 <4.0.0`
 - Add `resolution: workspace` to `pubspec.yaml` for workspace compatibility

Branch: dev
Base: main
Related to: cross-repo workspace change affecting 63 repositories
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates package configuration to opt into Dart pub workspace dependency resolution.

Changes:

  • Add resolution: workspace to pubspec.yaml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pubspec.yaml Outdated
environment:
sdk: '>=3.6.0 <4.0.0'

resolution: workspace
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolution: workspace is being added, but this repo doesn't appear to define a pub workspace (no workspace: section anywhere in the repo). If this package isn't actually part of a Dart pub workspace/monorepo, this setting is unnecessary and can confuse or affect dart pub get/CI behavior. Either remove resolution: workspace, or add the corresponding workspace root configuration (and additional package members) that makes workspace resolution meaningful.

Copilot uses AI. Check for mistakes.
pubspec.yaml Outdated
Comment on lines 9 to 12
environment:
sdk: '>=3.6.0 <4.0.0'

resolution: workspace
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the SDK constraint is being bumped to >=3.6.0 <4.0.0, but this pubspec.yaml already has that constraint. Either update the PR description to reflect the actual change (workspace resolution only), or include the intended SDK constraint change in the diff if it was missed.

Copilot uses AI. Check for mistakes.
pubspec.yaml Outdated
environment:
sdk: '>=3.6.0 <4.0.0'

resolution: workspace
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Adding resolution: workspace to pubspec.yaml will cause flutter pub get to fail for this public, standalone package because no workspace root is defined within the repository.
Severity: CRITICAL

Suggested Fix

Remove the resolution: workspace line from pubspec.yaml. As a publicly distributed package, it must be resolvable on its own without depending on an external monorepo workspace configuration.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: pubspec.yaml#L12

Potential issue: Adding `resolution: workspace` to the `pubspec.yaml` file breaks the
package for standalone usage. This package is published on pub.dev and is intended to be
used as a dependency in other projects. Without a parent directory containing a root
`pubspec.yaml` that defines a `workspace:`, any attempt to run `flutter pub get` on a
project using this package will fail with a resolution error. This makes the package
unusable for its primary audience and will break CI/CD pipelines that test the package
in isolation. The change assumes a monorepo structure that is not present in this
repository.

Did we get this right? 👍 / 👎 to inform future reviews.

- Update `environment.sdk` in `pubspec.yaml`.
- Set minimum Dart SDK version to `3.6.0`.

Branch: dev
Base: main
Related to: cross-repo workspace change affecting 62 repositories
@tsavo-at-pieces
Copy link
Author

smart-prs is closing this PR automatically.

Reason: 0 file changes between dev and master (2 commit(s) ahead but identical content).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant