-
Notifications
You must be signed in to change notification settings - Fork 0
Bump SDK constraints and add workspace resolution #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update Dart SDK constraint to `>=3.6.0 <4.0.0` - Add `resolution: workspace` to `pubspec.yaml` for workspace compatibility Branch: dev Base: main Related to: cross-repo workspace change affecting 63 repositories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates package configuration to opt into Dart pub workspace dependency resolution.
Changes:
- Add
resolution: workspacetopubspec.yaml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pubspec.yaml
Outdated
| environment: | ||
| sdk: '>=3.6.0 <4.0.0' | ||
|
|
||
| resolution: workspace |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolution: workspace is being added, but this repo doesn't appear to define a pub workspace (no workspace: section anywhere in the repo). If this package isn't actually part of a Dart pub workspace/monorepo, this setting is unnecessary and can confuse or affect dart pub get/CI behavior. Either remove resolution: workspace, or add the corresponding workspace root configuration (and additional package members) that makes workspace resolution meaningful.
pubspec.yaml
Outdated
| environment: | ||
| sdk: '>=3.6.0 <4.0.0' | ||
|
|
||
| resolution: workspace |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description says the SDK constraint is being bumped to >=3.6.0 <4.0.0, but this pubspec.yaml already has that constraint. Either update the PR description to reflect the actual change (workspace resolution only), or include the intended SDK constraint change in the diff if it was missed.
pubspec.yaml
Outdated
| environment: | ||
| sdk: '>=3.6.0 <4.0.0' | ||
|
|
||
| resolution: workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Adding resolution: workspace to pubspec.yaml will cause flutter pub get to fail for this public, standalone package because no workspace root is defined within the repository.
Severity: CRITICAL
Suggested Fix
Remove the resolution: workspace line from pubspec.yaml. As a publicly distributed package, it must be resolvable on its own without depending on an external monorepo workspace configuration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pubspec.yaml#L12
Potential issue: Adding `resolution: workspace` to the `pubspec.yaml` file breaks the
package for standalone usage. This package is published on pub.dev and is intended to be
used as a dependency in other projects. Without a parent directory containing a root
`pubspec.yaml` that defines a `workspace:`, any attempt to run `flutter pub get` on a
project using this package will fail with a resolution error. This makes the package
unusable for its primary audience and will break CI/CD pipelines that test the package
in isolation. The change assumes a monorepo structure that is not present in this
repository.
Did we get this right? 👍 / 👎 to inform future reviews.
- Update `environment.sdk` in `pubspec.yaml`. - Set minimum Dart SDK version to `3.6.0`. Branch: dev Base: main Related to: cross-repo workspace change affecting 62 repositories
|
smart-prs is closing this PR automatically. Reason: 0 file changes between |
Summary
This pull request updates the SDK constraints in
pubspec.yamlto support newer Dart versions and introduces workspace resolution for better dependency management within a monorepo setup. These changes ensure compatibility with the latest Flutter environment and streamline development workflows.Changes
environment.sdkconstraint to>=3.6.0 <4.0.0inpubspec.yaml.resolution: workspacetopubspec.yamlto enable workspace dependency resolution.