PID request for ES3ink board #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tannewt
requested changes
Jul 7, 2023
Collaborator
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Repo link doesn't work. Please also include a link in the hardware repo's readme to the software that will use this PID. (Your CircuitPython branch.)
Contributor
Author
|
Sorry, I created repo for my board and link now works. Are information in it OK to move this forward? Thanks |
tannewt
requested changes
Jul 11, 2023
Collaborator
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
No, you actually need the source published to be considered open source. You may want a PID from ESP instead. They don't require open source.
Contributor
Author
|
@tannewt Ok, so if I upload source files for the board to the Github, that will be enough to finish this PR? EDIT: |
Contributor
|
@tannewt Could you re-review? Thanks. |
tannewt
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.