Request for 0x1209/0xBEE5 VID/PID pair#450
Merged
Arachnid merged 2 commits intopidcodes:masterfrom Sep 4, 2019
Merged
Conversation
Contributor
Author
|
The hardware sources are all MIT licensed. The firmware that it runs is GPL-2.0 I don't know if I can list multiple or not |
Duckle29
changed the title
Contributor
Author
|
As this is a USB-HID device I moved to the 0x0--- range |
Contributor
Author
|
I noticed there were no orgs with spaces, so I looked through a few old PRs and found this: #301 as such I changed my org to be without spaces. |
Arachnid
requested changes
Sep 2, 2019
Contributor
Arachnid
left a comment
Arachnid
left a comment
There was a problem hiding this comment.
Please pick a PID >0x2000 - PIDs in the 0x0xxx range are reserved for general-purpose PIDs.
Duckle29
changed the title
Contributor
Author
|
Okay, I misinterpreted what was meant by that. Back to my original request of 0xBEE5 :) |
Arachnid
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used for an open-source keyboard