Skip to content

PID request for Intelectron Framework#245

Merged
Arachnid merged 4 commits intopidcodes:masterfrom
Intelectron:master
Jun 5, 2017
Merged

PID request for Intelectron Framework#245
Arachnid merged 4 commits intopidcodes:masterfrom
Intelectron:master

Conversation

@Intelectron
Copy link
Contributor

@Intelectron Intelectron commented Apr 8, 2017

Pull Request for the following VID/PID pairs

1209/a8b0
1209/a8b1

Added all index.md at once
Copy link
Contributor

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the ^M DOS line endings please.

@Intelectron
Copy link
Contributor Author

@peternewman , We've tried but due to some unknown reason, We arn't not being able to remove it (^M DOS ending).
Please suggest a workaround if possible.
Regards,
Intelectron Team

@uriba107
Copy link
Contributor

Your can either ensure your git client is not configured to push using CRLF
https://help.github.com/articles/dealing-with-line-endings/#platform-all

or you can just edit the files and remove it
Most fail proof way is on linux, open file in Nano, and save changes, when saving, you would see "(Dos line ending)" hit ALT+M to "disable" it and use unix, then save.

in windows just use a proper editor (notepad++, atom or whatever) - they all have the option to change line endings.

Set to UNIX EOL (LF)
@Intelectron
Copy link
Contributor Author

Intelectron commented May 18, 2017

Thank you for pointing the issue @peternewman,
Thank you for suggesting the solution @uriba107
We think it's fixed now. Can you verify ?

Copy link
Contributor

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a markdown perspective, you've fixed the DOS line endings @Intelectron .

@Arachnid Arachnid merged commit 9cf0fa7 into pidcodes:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants