Skip to content

Commit

Permalink
chore(release): 1.4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@davidcunha
davidcunha committed Jan 12, 2019
1 parent 33cf4ef commit e7bd834
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

<a name="1.4.2"></a>
## [1.4.2](https://github.com/picuscreative/testcafe-reporter-html/compare/v1.4.1...v1.4.2) (2019-01-12)


### Bug Fixes

* screenshots multiple failed tests, escaped html in error code ([428812e](https://github.com/picuscreative/testcafe-reporter-html/commit/428812e))



<a name="1.4.1"></a>
## [1.4.1](https://github.com/picuscreative/testcafe-reporter-html/compare/v1.4.0...v1.4.1) (2018-12-22)

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "testcafe-reporter-html",
"version": "1.4.1",
"version": "1.4.2",
"description": "The HTML reporter for TestCafe",
"keywords": [
"testcafe",
Expand Down

3 comments on commit e7bd834

@timnederhoff
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidcunha,
Can you tell me how the package v1.4.2 is published to npmjs? In the published packet, I find this code in reportTaskDone():

this.write(html);

try {
  fs.writeFileSync('./index.html', html);
} catch (e) {
  console.log('Cannot write file ', e);
}

So the content is written twice to a file. while this.write(html) should be the only writing line. I'm afraid the package is published with old code (I remember that I removed these lines in commit f24f206).

@davidcunha
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timnederhoff Yeah, I was validating the comment from issue #16 (comment) and found that something should be incorrect with the build from 1.4.2 because when linking the dependency locally everything worked correctly.

I'm using standard-version that in turn git push --follow-tags origin master && npm publish. Probably the build file is old since we removed it lib with .npmignore.

@timnederhoff
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, so the package can be build and published again. Maybe a new checkout to start clean?

Please sign in to comment.