Window OnLoadComplete and GetPreferredSize improvements #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cwensley
commented
Sep 23, 2024
cwensley
commented
- OnLoadComplete is now called by Window handler implementations at the appropriate time
- Window.GetPrerredSize() should now be guaranteed to work for a Window during the LoadComplete event on all platforms, and for some platforms before it is shown.
- Gtk still has issues including the window decorations with the preferred size, work is ongoing there.
- Mac now calls Window.Shown after children get the same event, like other platforms.
- OnLoadComplete is now called by Window handler implementations at the appropriate time - Window.GetPrerredSize() should now be guaranteed to work for a Window during the LoadComplete event on all platforms, and for some platforms before it is shown. - Gtk still has issues including the window decorations with the preferred size, work is ongoing there. - Mac now calls Window.Shown after children get the same event, like other platforms.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.