Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the virtual method CreateControl on wpf DrawableHandler #2458

Conversation

eng-myousif
Copy link
Contributor

  • Provide a generic version of DrawableHandler to be able to provide custom control, widget and callback.

  • Make use of the virtual method CretaeControl when creating the wpf canvas for the drawable control.

  • This is required to enable the extending the drawable control when needed by a custom canvas.

  • That was required in our case because we needed to provide a custom automation peer for the wpf canvas. and we could only do that by providing a custom canvas to the drawable.

  • To make use the EtoMainCanvas I had to make it public.

* Make use of the virtual method `CretaeControl` when creating the
wpf canvas for the drawable control.

* This is required to enable the extending the drawable control when
needed by a custom canvas.

* That was required in our case because we needed to provide a
custom automation peer for the wpf canvas. and we could only do that
by providing a custom canvas to the drawable.
@eng-myousif eng-myousif changed the title Make use of the virtual method CretaeControl on wpf DrawableHandler Make use of the virtual method CreateControl on wpf DrawableHandler Apr 3, 2023
@eng-myousif
Copy link
Contributor Author

Hi @cwensley,
For the other pull request I've noticed there go through checks like build_windows and build_mac - the third tab in the pull request - but it is not the case in my pul request. Do I need to do something from my side in that regards?

Also I would like to highlight that this pull request should help us to be able to automate some important part in our product. Hence it is so appreciated to have a look into my pull request, thanks in advance!

Copy link
Member

@cwensley cwensley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eng-myousif, thanks for taking the time to put this together! I think after the one change this should be good to go.

src/Eto.Wpf/Forms/Controls/DrawableHandler.cs Outdated Show resolved Hide resolved
@cwensley cwensley merged commit ea1d236 into picoe:develop Apr 16, 2023
@cwensley cwensley added this to the 2.8.0 milestone Apr 16, 2023
@eng-myousif
Copy link
Contributor Author

Hi @cwensley , Thanks for merging the suggested enhancement.

I see the assigned milestone is 2.8.0 and I am expecting this will take some time to be released.
Is it possible to have this enhancement in a patch release then we get it sooner as we needed asap?

@cwensley
Copy link
Member

@eng-myousif absolutely, that is not a problem. I just pushed out 2.7.5. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants