[Mac] use proper text alignment on arm64 #2438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextAlignment Right and Center are switched up on Arm64 Macos.
|
Thanks for the fix @Miepee! I'm not sure if the net7.0-macos workload already deals with this so that needs to be looked into first. If it does, the fix should probably go into MonoMac instead of in Eto. |
|
Does the net7.0 workload use xamarin? if yes, it seems to have been merged about a year ago: xamarin/xamarin-macios#12111 |
|
Yes they are the same. So we should do a similar fix for the MonoMac submodule instead. |
|
Gotcha, will mark as ready to review then when I moved the fix to monomac. |
|
Guess i was too slow, sorry for that |
|
No worries @Miepee, I hope you didn't put too much work into it. I needed it for one of my projects so I thought I'd take a crack at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextAlignment Right and Center are switched up on Arm64 Macos. So this PR fixes this by giving the switched up version in the ToEto/ToNS functions if the current running system is Arm.
Fixes #2250 (don't have a mac device currently, so didn't actually test).