Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: Fix issues autosizing columns in some cases #2359

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

cwensley
Copy link
Member

@cwensley cwensley commented Dec 2, 2022

Simplified the logic for autosizing by removing the intercell spacing before calculating the column sizes. Unfortunately, the insets used for the different NSTableViewStyle values cannot be retrieved by any particular APIs so it needs to be hard coded.

  • Now properly handles all the different styles of NSTableView/NSOutlineView from Big Sur and later
  • Fixed warning in test app with unreachable code
  • Fixed warning when running wrt. the EtoFontManager constructor.
  • Added unit tests for all cases and tested on macOS 10.15, 11, 12, and 13.

- Now properly handles all the different styles of NSTableView/NSOutlineView from Big Sur
- Fixed warning in test app with unreachable code
- Fixed warning when running wrt. the EtoFontManager constructor.
@cwensley cwensley added the bug label Dec 2, 2022
@cwensley cwensley added this to the 2.7.3 milestone Dec 2, 2022
@cwensley cwensley merged commit d51ed9c into picoe:develop Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant