Make setting DataContext non destructive to view models #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a new DataContext to a control with an existing context, bindings could trigger events that would update other bindings before to either the new or old data context inadvertently. With these changes, any updated bindings will no longer modify the view model when they trigger other events. - Added IBindable.IsDataContextChanging which all controls inherit which can be used to perform specific logic during data context updates. - Added ObjectBinding.GetDataItem/TriggerDataValueChanged so it no longer has to store the data context object directly, causing all bindings to get the new data context immediately instead of one at a time - BindableBinding.BindDataContext() will no longer update the source values (view model) during a data context update. - Added a unit test to ensure desired behaviour of switching data contexts in this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a new DataContext to a control with an existing context, bindings could trigger events that would update other bindings before to either the new or old data context inadvertently. With these changes, any updated bindings will no longer modify the view model when they trigger other events.