Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wpf: Fix crash when closing a Dialog #2132

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

cwensley
Copy link
Member

This was a regression introduced in #2131, calling Dialog.Close() causes the following exception:

System.InvalidOperationException: 'Cannot set Owner property after Dialog is shown.'
[External Code]	
Eto.Wpf.dll!Eto.Wpf.Forms.WpfWindow<System.Windows.Window, Eto.Forms.Dialog, Eto.Forms.Window.ICallback>.SetOwner(Eto.Forms.Window owner) Line 897	C#
Eto.Wpf.dll!Eto.Wpf.Forms.WpfWindow<System.Windows.Window, Eto.Forms.Dialog, Eto.Forms.Window.ICallback>.Close() Line 412	C#
Eto.dll!Eto.Forms.Window.Close() Line 327	C#
ZooClient.dll!ZooClient.ClientManager._PerformCloudZooTask.AnonymousMethod__5() Line 1952	C#
[External Code]	
Eto.Wpf.dll!Eto.Wpf.Forms.DialogHandler.ShowModal() Line 62	C#
Eto.dll!Eto.Forms.Dialog.ShowModal() Line 225	C#
Eto.dll!Eto.Forms.Dialog.ShowModal(Eto.Forms.Control owner) Line 207	C#
Eto.dll!Eto.Forms.Dialog<bool>.ShowModal(Eto.Forms.Control owner) Line 87	C#

@cwensley cwensley added the bug label Jan 31, 2022
@cwensley cwensley added this to the 2.6.2 milestone Jan 31, 2022
@cwensley cwensley force-pushed the curtis/wpf-fix-dialog-owner-crash branch from 9dbdeed to 2a5b584 Compare January 31, 2022 22:26
@cwensley cwensley force-pushed the curtis/wpf-fix-dialog-owner-crash branch from 2a5b584 to 10e26bd Compare January 31, 2022 22:26
@cwensley cwensley merged commit 0efdb4b into picoe:develop Jan 31, 2022
@cwensley cwensley deleted the curtis/wpf-fix-dialog-owner-crash branch January 31, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant