Setting e.Cancel = true in Splitter.PositionChanging event should can…

…cel any changes
picoe · Jul 6, 2023 · 41d1e3b · 41d1e3b
1 parent 5c436ca
commit 41d1e3b
Show file tree

Hide file tree

Showing 5 changed files with 245 additions and 200 deletions.
diff --git a/src/Eto.Mac/Forms/Controls/SplitterHandler.cs b/src/Eto.Mac/Forms/Controls/SplitterHandler.cs
@@ -296,9 +296,13 @@ public override void DidResizeSubviews(NSNotification notification)
 					var mainFrame = h.Control.Frame;
 					if (mainFrame.Width <= 1 || mainFrame.Height <= 1)
 						return;
-					h.position = h.Control.IsVertical ? (int)subview.Frame.Width : (int)subview.Frame.Height;
+					var newPosition = h.Control.IsVertical ? (int)subview.Frame.Width : (int)subview.Frame.Height;
 					h.TriggerChangeStarted();
-					h.Callback.OnPositionChanged(h.Widget, EventArgs.Empty);
+					if (newPosition != h.position)
+					{
+						h.position = newPosition;
+						h.Callback.OnPositionChanged(h.Widget, EventArgs.Empty);
+					}
 				}
 			}
 

diff --git a/src/Eto.WinForms/Forms/Controls/SplitterHandler.cs b/src/Eto.WinForms/Forms/Controls/SplitterHandler.cs
@@ -161,6 +161,9 @@ private void CheckSplitterPos(bool userMoved)
 				newPosition = lastPosition;
 			}
 
+			// always set splitter distance 
+			Control.SplitterDistance = newPosition;
+
 			if (lastPosition != newPosition)
 			{
 				if (Control.IsHandleCreated)
@@ -170,9 +173,9 @@ private void CheckSplitterPos(bool userMoved)
 					position = newPosition;
 					Callback.OnPositionChanged(Widget, EventArgs.Empty);
 				}
-
-				Control.SplitterDistance = newPosition;
 			}
+
+
 			lastPosition = newPosition;
 
 			if (userMoved)