Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged PR, removed SCSS warnings, added rows, columns, :user-valid, labels to groups and more #638

Open
wants to merge 113 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
dada435
Add date to list of excluded input types.
y2kbugger Apr 23, 2024
0810f1e
fix: Card in modal does not use modal styling
Zurga Apr 26, 2024
455339f
Allow use of card component with `role="article"`
lukas-kasticky May 25, 2024
72e4699
fix: don't count hidden rows in table stripes
feored Aug 3, 2024
6fabc27
Update _tooltip.scss
panda-madness Aug 6, 2024
c3bcecb
refactor: move nested declarations after non-nested declarations
nstringham Aug 18, 2024
f516207
chore: build
nstringham Aug 18, 2024
dc7f6d0
Fix several typos throughout the project
preist Sep 27, 2024
6f3abc2
Fix details inside drop-down being rendered as dropdown
mwargan Sep 28, 2024
b3a731b
Update _loading.scss not to affect form elements itself
coezbek Oct 31, 2024
c77d19e
Merge pull request #5 from nstringham/mixed-sass-declarations
Yohn Nov 10, 2024
93d9675
Merge pull request #10 from Zurga/fix/modal_with_card
Yohn Nov 10, 2024
de9b7d4
Merge pull request #9 from y2kbugger/main
Yohn Nov 10, 2024
2fc4ad2
Merge pull request #7 from feored/fix-striped-table
Yohn Nov 10, 2024
9ef9bfe
Merge pull request #3 from coezbek/main
Yohn Nov 10, 2024
bdf50fe
Merge pull request #2 from preist/fix-typos
Yohn Nov 10, 2024
e1348d0
Merge pull request #4 from mwargan/patch-1
Yohn Nov 10, 2024
fe62017
Merge pull request #8 from panda-madness/patch-1
Yohn Nov 10, 2024
9617cb1
Merge branch 'main' into pr/Yohn/6
Yohn Nov 10, 2024
4825b26
closes Yohn/PicoCSS/pull/1 and Yohn/PicoCSS/pull/11
Yohn Nov 10, 2024
a085c20
surpressimg sass warnings
Yohn Nov 10, 2024
2c8e70a
Merge pull request #13 from Yohn/Surpressing-sass-warnings
Yohn Nov 10, 2024
84ed38e
Added Notifications 12
Yohn Nov 10, 2024
fe78285
Finally stopped all the sass compile warnings, changed the tab-size t…
Yohn Nov 10, 2024
b1fcd44
Added <label> compatibility to groups
Yohn Nov 12, 2024
26e82a6
Created build-dev script to only build 1 css file for quicker testing…
Yohn Nov 12, 2024
359e51e
Added a Timeline feature, removed the margin-bottom from `article > h…
Yohn Nov 12, 2024
7602474
Added form validation
Yohn Nov 13, 2024
b611b52
Got the file validation and previewer lines up nicer
Yohn Nov 13, 2024
42b62b1
V. 2.1.0 - Yohns Fork
Yohn Nov 27, 2024
68a9fb9
Update css urls
Yohn Nov 27, 2024
fdf5c83
Enabled multiline tooltips, and disabled dotted lines for tooltips wh…
Yohn Nov 30, 2024
02c9fb6
Support web components/shadow DOM.
rcoup Dec 2, 2024
a8bbc68
Merge pull request #15 from lukas-kasticky:dev
Yohn Dec 3, 2024
5d2e82d
Merge pull request #16 from rcoup/web-components-host
Yohn Dec 3, 2024
7f28ea0
Updated Docs
Yohn Dec 3, 2024
137d6bf
Remove pointer cursor #14
Yohn Dec 3, 2024
7ce5b5c
rebuilt css files, For some reason was having issues with the line en…
Yohn Dec 3, 2024
3548875
Changed spacing on form elements to be a tad smaller. It was just too…
Yohn Dec 8, 2024
8b6c0ef
Update README.md
Yohn Dec 10, 2024
a937be4
Update README.md
Yohn Dec 10, 2024
f25840f
- Updated form validation to not validate when form[novalidate]
Yohn Dec 10, 2024
bfdf6db
Update index.html
Yohn Dec 10, 2024
5e37f38
Support RTL for group component border radius styles
remohammadi Dec 11, 2024
6359082
Add RTL support for Accordion Marker
remohammadi Dec 11, 2024
828d1f3
Merge pull request #18 from remohammadi/main
Yohn Dec 12, 2024
b7100d2
Merged RTL pull request into css files, and updated docs for hamburge…
Yohn Dec 13, 2024
8a7b25a
Improved visibility of loading icon in light mode on contrast backgro…
Yohn Dec 13, 2024
64373c2
RTL Dropdown Nav corrected thanks to @64bitint
Yohn Dec 14, 2024
0104f7d
tweaks to safari bug with nav dropdowns
Yohn Dec 14, 2024
9faf591
sass is removing the "\200B" value and leaving it blank? I put a spac…
Yohn Dec 14, 2024
27ccea2
sass compiler was removing the value: "\200B" for the :where(navs li).
Yohn Dec 14, 2024
130b1cd
Final iOS 18.2 bug fix for [dir=rtl] dropdowns
Yohn Dec 14, 2024
a6325b8
corrected dropdown arrow colors for secondary, contrast, and primary.…
Yohn Dec 15, 2024
3cfdc97
Corrected Dropdown > Submenu formatting and alignment
Yohn Dec 15, 2024
dbd9c5a
Cards keep style with form tag wrapped around header and footer in ar…
Yohn Dec 15, 2024
e0abc58
Version 2.2.1
Yohn Dec 21, 2024
cd0d303
Update CDN CSS url to use 2.2.1
Yohn Dec 21, 2024
3c52bb3
Removed unused docs and docs/js files
Yohn Dec 22, 2024
b801937
Create node.js.yml
Yohn Dec 22, 2024
8be4490
Update and rename .github/workflows/node.js.yml to .github/auto-build…
Yohn Dec 22, 2024
03188f3
Create GitHub Action to BuildCSS.yml
Yohn Dec 23, 2024
b83c181
Build CSS
github-actions[bot] Dec 23, 2024
e30f662
Create FUNDING.yml
Yohn Dec 23, 2024
a5ebfad
Build CSS
github-actions[bot] Dec 23, 2024
324f6fc
Update BuildCSS.yml
Yohn Dec 23, 2024
ddf41a1
Closes Legend element not styled in `role="group"` Yohn/PicoCSS#23
Yohn Dec 31, 2024
951aae3
Build CSS
github-actions[bot] Dec 31, 2024
973e8a0
Fix RTL margin handling in group component
remohammadi Jan 2, 2025
cde9f11
Build CSS
github-actions[bot] Jan 2, 2025
db14c89
Merge pull request #25 from remohammadi/main
Yohn Jan 3, 2025
5677e11
Build CSS
github-actions[bot] Jan 3, 2025
8533005
Reverted back to before prettier
Yohn Jan 11, 2025
6165606
Build CSS
github-actions[bot] Jan 11, 2025
857d526
Updated tabs to work with multiple tabs on same page and nested tabs
Yohn Jan 11, 2025
f4ccc51
Merge branch 'main' of github.com:Yohn/PicoCSS
Yohn Jan 11, 2025
9a9032f
New switch light / dark mode toggle
Yohn Jan 11, 2025
d0e2123
Build CSS
github-actions[bot] Jan 11, 2025
712b0a1
Closes #32 and brings the arrow back to the tooltips
Yohn Jan 11, 2025
db7b0b2
Build CSS
github-actions[bot] Jan 11, 2025
d20ea65
Closes #30 dicussion as modal sizes have now been added with this com…
Yohn Jan 11, 2025
f9c3a34
Build CSS
github-actions[bot] Jan 11, 2025
277384d
2.2.3
Yohn Jan 11, 2025
f8fbce3
Build CSS
github-actions[bot] Jan 11, 2025
eb1304a
enhanced the tooltip to have a width of `max-content` and a max width…
Yohn Jan 14, 2025
9271ce8
Build CSS
github-actions[bot] Jan 14, 2025
3946e8f
Improve Inline Code Spacing
irfanfadilah Jan 14, 2025
37dac63
Fix Pre Code Overflow
irfanfadilah Jan 14, 2025
5486f69
Update CONTRIBUTING.md
Yohn Jan 14, 2025
8b09efb
Merge pull request #36 from irfanfadilah/yohn/improve-code-rendering
Yohn Jan 14, 2025
2955c38
Build CSS
github-actions[bot] Jan 14, 2025
16283c5
Only make first level children of tablist button[role="tab"]'s styles…
Yohn Jan 14, 2025
0875d75
Build CSS
github-actions[bot] Jan 14, 2025
5658845
Striped table rows updated
Yohn Jan 17, 2025
39da3b6
Build CSS
github-actions[bot] Jan 17, 2025
ddd46d9
Added submenus to work with hamburger menu
Yohn Jan 17, 2025
d4baa32
Build CSS
github-actions[bot] Jan 17, 2025
03cf590
Closes [BUG] Striped table does not work on minified pico css version…
Yohn Jan 17, 2025
c1ef8d7
Build CSS
github-actions[bot] Jan 17, 2025
3c91189
2.2.6 - cleancss fix for minifying error on on the striped tables #42
Yohn Jan 17, 2025
4af8d13
Build CSS
github-actions[bot] Jan 17, 2025
74b3d55
Update form ID for validation and add new entry to .gitignore
Yohn Jan 17, 2025
0708656
Removed the pull request workflow
Yohn Jan 18, 2025
9ea0a83
Updated the clean-css filter to ignore the `odd of` lines so it doesn…
Yohn Jan 18, 2025
389e319
Build CSS
github-actions[bot] Jan 18, 2025
6bc6d79
Fixes header and footer in modal when form is direct child of the art…
Yohn Jan 19, 2025
35dff83
Merge pull request #45 from Yohn/Modal-forms
Yohn Jan 19, 2025
db3dc3b
Build CSS
github-actions[bot] Jan 19, 2025
30e7710
Prevent the FileValidator's remove button from bubbling up and closin…
Yohn Jan 19, 2025
b4e4b87
Merge pull request #46 from Yohn/FileValidator-remove-file-bubbling-up
Yohn Jan 19, 2025
6054ddc
Floating label was moving on the textareas when the textareas grow
Yohn Jan 20, 2025
2ed6335
Merge pull request #48 from Yohn/textarea-floating-labels
Yohn Jan 20, 2025
af735a6
Build CSS
github-actions[bot] Jan 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix RTL margin handling in group component
I had made a mistake previously by putting the RTL margin styles one level higher than where it belonged.
  • Loading branch information
remohammadi committed Jan 2, 2025
commit 973e8a0fd83e3bd13579cf42e10c6fe5da0978b4
28 changes: 14 additions & 14 deletions scss/components/_group.scss
Original file line number Diff line number Diff line change
Expand Up @@ -189,21 +189,21 @@
border-bottom-left-radius: 0;
}
}
}

button,
[type="submit"],
[type="reset"],
[type="button"],
[role="button"],
input:not([type="checkbox"], [type="radio"]),
select,
label,
> legend,
> details > summary {
&:not(:first-child) {
margin-right: calc(var(#{$css-var-prefix}border-width) * -1);
margin-left: auto;
button,
[type="submit"],
[type="reset"],
[type="button"],
[role="button"],
input:not([type="checkbox"], [type="radio"]),
select,
label,
> legend,
> details > summary {
&:not(:first-child) {
margin-right: calc(var(#{$css-var-prefix}border-width) * -1);
margin-left: auto;
}
}
}
}
Expand Down