Skip to content

Detect existing issues by title and GitLab URL to avoid skipping an item #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Detect existing issues by title and GitLab URL to avoid skipping an item #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ async function transferIssues() {
for (let issue of issues) {
// try to find a GitHub issue that already exists for this GitLab issue
let githubIssue = githubIssues.find(
i => i.title.trim() === issue.title.trim()
i => i.title.trim() === issue.title.trim() && i.body.includes(issue.web_url)
);
if (!githubIssue) {
console.log(`\nMigrating issue #${issue.iid} ('${issue.title}')...`);
Expand Down Expand Up @@ -563,14 +563,14 @@ async function transferMergeRequests() {
// Try to find a GitHub pull request that already exists for this GitLab
// merge request
let githubRequest = githubPullRequests.find(
i => i.title.trim() === mr.title.trim()
i => i.title.trim() === mr.title.trim() && i.body.includes(mr.web_url)
);
let githubIssue = githubIssues.find(
// allow for issues titled "Original Issue Name - [merged|closed]"
i => {
// regex needs escaping in case merge request title contains special characters
const regex = new RegExp(escapeRegExp(mr.title.trim()) + ' - \\[(merged|closed)\\]');
return regex.test(i.title.trim());
return regex.test(i.title.trim()) && i.body.includes(mr.web_url);
}
);
if (!githubRequest && !githubIssue) {
Expand Down