-
Notifications
You must be signed in to change notification settings - Fork 45
Adds a guide to contributing documents #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a guide to contributing documents #461
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 93.42% 94.04% +0.62%
==========================================
Files 5 5
Lines 365 403 +38
==========================================
+ Hits 341 379 +38
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed? |
docs/source/contributing/index.rst
Outdated
|
|
||
| The docs are written using Sphinx. To get them running locally: | ||
|
|
||
| * Install the requirements: ``pip install -r requirements/readthedocs-requirements.txt`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this just be requirements/doc-requirements.txt instead of requirements/readthedocs-requirements.txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. If we run make html with previous pip install -r requirements/doc-requirements.txt, we will get ModuleNotFoundError
(doc_env) rkl@mint:~/dev/doc_env/piccolo_admin/docs$ make html
Running Sphinx v7.3.7
Configuration error:
There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/home/rkl/dev/doc_env/lib/python3.12/site-packages/sphinx/config.py", line 509, in eval_config_file
exec(code, namespace) # NoQA: S102
^^^^^^^^^^^^^^^^^^^^^
File "/home/rkl/dev/doc_env/piccolo_admin/docs/source/conf.py", line 29, in <module>
import piccolo_admin # noqa
^^^^^^^^^^^^^^^^^^^^
File "/home/rkl/dev/doc_env/piccolo_admin/piccolo_admin/__init__.py", line 1, in <module>
from .endpoints import FormConfig, create_admin
File "/home/rkl/dev/doc_env/piccolo_admin/piccolo_admin/endpoints.py", line 19, in <module>
import typing_extensions
ModuleNotFoundError: No module named 'typing_extensions'
make: *** [Makefile:20: html] Error 2With readthedocs-requirements.txt we don't have this problem because we use full requirements in that file
| -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. Can we do this instead:
* Make sure the main requirements are installed: ``pip install -r requirements/requirements.txt``
* Install the documentation requirements: ``pip install -r requirements/requirements.txt``
I know it sounds weird, but I don't want to reference the readthedocs requirements, just because I want to keep that just for readthedocs, and we might move away from them in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
Looks great, thanks! |
Related to #459