Skip to content

Add device orientation control to rover controller #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

angusjfw
Copy link
Contributor

Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #543 (8712dc7) into master (6bdf48c) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   57.29%   56.93%   -0.37%     
==========================================
  Files         146      146              
  Lines        6920     6929       +9     
==========================================
- Hits         3965     3945      -20     
- Misses       2955     2984      +29     
Flag Coverage Δ
unittests 56.93% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pitop/labs/web/blueprints/messaging/__init__.py 0.00% <0.00%> (ø)
pitop/labs/web/blueprints/rover/__init__.py 0.00% <0.00%> (ø)
pitop/labs/web/webcontroller.py 0.00% <ø> (ø)
pitop/labs/web/webserver.py 0.00% <0.00%> (ø)
pitop/processing/core/load_models.py 44.89% <0.00%> (-40.82%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@angusjfw angusjfw force-pushed the rover-mobile-orientation-control branch 11 times, most recently from 8eb46e4 to d4d4d0a Compare June 23, 2022 16:14
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@pi-top pi-top deleted a comment from lgtm-com bot Jun 23, 2022
@angusjfw angusjfw force-pushed the rover-mobile-orientation-control branch 2 times, most recently from 38fbe1c to 6bf4540 Compare June 23, 2022 16:26
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2022

This pull request introduces 1 alert when merging 6bf4540 into 460879b - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2022

This pull request introduces 1 alert when merging 8f32f84 into 460879b - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@angusjfw angusjfw force-pushed the rover-mobile-orientation-control branch from 8f32f84 to feef61e Compare June 24, 2022 15:54
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2022

This pull request introduces 1 alert when merging feef61e into 54d2542 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@angusjfw angusjfw force-pushed the rover-mobile-orientation-control branch from feef61e to ed89664 Compare June 24, 2022 16:10
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2022

This pull request introduces 1 alert when merging ed89664 into 54d2542 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2022

This pull request introduces 1 alert when merging e215ec1 into 54d2542 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@angusjfw angusjfw force-pushed the rover-mobile-orientation-control branch from e215ec1 to 2814478 Compare June 24, 2022 20:36
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2022

This pull request introduces 1 alert when merging 2814478 into 54d2542 - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented Aug 15, 2022

This pull request introduces 1 alert when merging 8712dc7 into 6bdf48c - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant