Skip to content

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 6, 2025

What does this PR aim to accomplish?:

Currently, the cpu and mem stats for FTL are less frequently updated than the total cpu and mem stats on the settings/system page. Reason is, that FTL stats are refreshed only every 2 minutes (REFRESH_INTERVAL.ftl), but total cpu and mem every 20 seconds ( REFRESH_INTERVAL.system).

This PR builds upon pi-hole/FTL#2645 which provides FTL's CPU and mem share within the /info/system endpoint as well.

How does this PR accomplish the above?:

Move the update function from updateFtlInfo() to updateSystemInfo()


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser yubiuser requested a review from a team as a code owner October 6, 2025 19:24
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser
Copy link
Member Author

yubiuser commented Oct 7, 2025

Second commit adds
Screenshot from 2025-10-07 07-03-50

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge only when the FTL PR is merged, too

@rdwebdesign
Copy link
Member

Actually this PR can be merged any time.
It relies on the already merged PR pi-hole/FTL#2645.

The other FTL PR just improves the previous one.

@DL6ER DL6ER merged commit 68e8675 into development Oct 7, 2025
11 checks passed
@DL6ER DL6ER deleted the improve_cpu branch October 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants