Skip to content

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Accompanies pi-hole/FTL#2531

Rename config key dns.domain > dns.domain.name


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser yubiuser requested a review from a team as a code owner September 28, 2025 08:43
@yubiuser yubiuser requested a review from DL6ER September 28, 2025 08:44
@DL6ER
Copy link
Member

DL6ER commented Sep 28, 2025

HOLD merging until pi-hole/FTL#2531 is merged, too.

@DL6ER DL6ER added the ON HOLD label Sep 28, 2025
@yubiuser
Copy link
Member Author

FTL PR has been merged.

@yubiuser yubiuser merged commit a6c372e into development Sep 30, 2025
10 checks passed
@yubiuser yubiuser deleted the dns.domain.name branch September 30, 2025 17:38
@DL6ER DL6ER removed the ON HOLD label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants