Make DNSSEC icon conditional in Queries Log

[sharkboots75]

---

What does this PR aim to accomplish?:

Avoid emitting the DNSSEC icon in Domain column if DNSSEC is not being used/tracked

How does this PR accomplish the above?:

Check for (dnssec.color !== "") which is the same convention used elsewhere in the script

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[rdwebdesign]

This is what we had before this commit 8f57898.
Lines containing icons are not aligned with lines without them:

[sharkboots75]

Oh I see this was done intentionally. Personally I think left aligned is the overall better option. Is it worth checking if we can render based on the global setting of DNSSEC rather than the data returned for each row?

(Noting also that long urls wrap around that icon, at least on all browsers I've tried)

[rdwebdesign]

I agree we need to find a better solution for the icon alignment.

When we introduced this icon the initial proposal didn't align the icons at all, so I suggested 2 options (left and right aligned).
We eventually decided to use the left aligned solution, but can be changed.

(Noting also that long urls wrap around that icon, at least on all browsers I've tried)

This can be fixed using CSS. A quick solution would be to add padding-left to the table cell and position: absolute to the icon, plus top: and left: adjustments (this will create a space on the left for the icon and fix the ugly misalignment when long domains wrap).

Maybe we can use a different CSS, or something completely different for the icon.

We can leave your PR opened as a discussion while we think about solutions.

[sharkboots75]

Made some further changes that makes it work the way I'd like it to.

Just a suggestion and I've only done adhoc client testing (FF, Chrome, Edge, Safari) but it's working everywhere I can check.

DNSSEC on:

DNSSEC off:

[yubiuser]

@sharkboots75 Tests are failing.

---

How does it look like with DNSSEC on, but lines with and without DNSSEC info? Do they still align?

[sharkboots75]

How does it look like with DNSSEC on, but lines with and without DNSSEC info? Do they still align?

Yes, urls always align to the other urls since doDnssec setting is global (not per-row)

[yubiuser]

Tests complaining

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Existing merge conflicts have not been addressed. This PR is considered abandoned.