-
-
Notifications
You must be signed in to change notification settings - Fork 222
RFC: add architecture documentation inspired by the C4 model approach #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Looking at: the preview, to make this truly valuable, we would need to
I would tend to option 1. |
Should be pretty simple: https://squidfunk.github.io/mkdocs-material/reference/diagrams/ |
9615a61
to
76a2a21
Compare
Before you invest more time in this PR: While it looks interesting at first to see the inner workings depicted, I'm not sure how much benefit users get from this. If I had no clue how Pi-hole works, the figures might not help much as they are very complex (as is Pi-hole). |
These diagrams are aimed at potential contributors, not general users, to aid understanding of Pi-hole's internals.
A very reasonable concern. Place this under |
Signed-off-by: Lars Artmann <git@lars.software>
Signed-off-by: Lars Artmann <git@lars.software>
Signed-off-by: Lars Artmann <git@lars.software>
76a2a21
to
067fff4
Compare
I think your suggestion is interesting, but the diagrams seems too complex. In my opinion, only users that already understand how Pi-hole works will understand the images.
Sometimes we forget to update some things, but adding information we already know will be outdated is a bad practice. |
Good point. We don't need to include all of the charts I suggested. I can see how charts 1 and 2 could change, but the 3rd (flow) chart should remain fairly stable, shouldn't it? |
What does this PR aim to accomplish?:
I was searching for a architecture diagram of pihole's internals. Since I was unable to find one, I created this.
Images
How does this PR accomplish the above?:
The PR adds a new
architecture.md
file in themain
folder.The new file includes multiple
mermaid
sections that can be easily rendered into good looking diagrams.Open Issue:
I did not manage to test my changes.
mkdocs build
andmkdocs serve
do not work for because of issue(s) with the template.Note
My understanding of the whole projects architecture is limited, it is very possible some of the diagrams have mistakes.
I do think it is a good start though. Input or changes are very welcome!