Skip to content

Fix grammar, style, and formatting in Approximate Matching doc #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

its-dave
Copy link
Contributor

@its-dave its-dave commented May 4, 2025

What does this PR aim to accomplish?:

Tidy the wording and syntax in docs/regex/approximate.md as some of it didn't make sense or was inconsistent


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

its-dave added 2 commits May 3, 2025 19:31
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Copy link

netlify bot commented May 4, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 6650ff2
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/6828a10870f03f0008473cbf
😎 Deploy Preview https://deploy-preview-1240--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdwebdesign rdwebdesign requested review from DL6ER and a team May 5, 2025 00:54
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
@yubiuser yubiuser requested a review from rdwebdesign May 6, 2025 14:27
@rdwebdesign
Copy link
Member

I'd like to know @DL6ER opinion here, because he is the original author of this page.

@rdwebdesign rdwebdesign removed their request for review May 18, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants