Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tini from image, we don't need it as we're handling all the ex… #1651

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

After some more handling added in #1649 - we realised that tini isn't actually doing anything. Lets save 0.1Mb in image size! 🙃


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

…its etc in start.sh

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux requested a review from a team October 11, 2024 17:15
@PromoFaux PromoFaux merged commit e5277ce into development Oct 11, 2024
5 checks passed
@PromoFaux PromoFaux deleted the tini-not-needed branch October 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants