fix: link related spaces / properties directly #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0ac184d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04c20cad.topology.pages.dev |
| Branch Preview URL: | https://related-links.topology.pages.dev |
this should significantly speed up end-to-end testing time and cut down on intermittent timeouts caused by waiting for deduction to fully complete
jamesdabbs
commented
Nov 6, 2023
There was a problem hiding this comment.
This is the newly added regression test.
|
|
||
| it('links to properties', () => { | ||
| cy.visit('spaces/S000004/properties') | ||
| deduce() |
There was a problem hiding this comment.
Because we are increasingly adding these "wait for deduction" blocks, we want to make sure that deduction run stays fast (and – importantly – within the timeout).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #67
🔬 Review Notes
This looks like a lot of lines changed, but almost all of it is trimming down and (auto)formatting the end-to-end fixtures file. Ignore that one 😜