forked from apache/kyuubi
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KYUUBI apache#4554] [CHAT] Code improvement in ChatGPTProvider
### _Why are the changes needed?_ - set authentication as default header in client construction instead of request construction - handle response's status code in scala style - transforming config's long value to int with `.intValue` instead of `asInstanceOf` casting - fix var name to `response` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#4554 from bowenliang123/chatgpt-http. Closes apache#4554 114484a [liangbowen] httpclient improvement in ChatGPTProvider Authored-by: liangbowen <liangbowen@gf.com.cn> Signed-off-by: Cheng Pan <chengpan@apache.org>
- Loading branch information
1 parent
6ded079
commit 067c601
Showing
1 changed file
with
24 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters