Fix inconsistent profile names with different AWS partitions#133
Merged
slycoder merged 1 commit intophysera:masterfrom Oct 16, 2018
Merged
Fix inconsistent profile names with different AWS partitions#133slycoder merged 1 commit intophysera:masterfrom
slycoder merged 1 commit intophysera:masterfrom
Conversation
AWS has multiple partitions e.g aws-cn or aws-us-gov which where previously not properly handled and cause not consistent OneLogin profile names. See in addition: - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/pseudo-parameter-reference.html#cfn-pseudo-param-partition
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 77.01% 76.85% -0.17%
==========================================
Files 6 6
Lines 335 337 +2
==========================================
+ Hits 258 259 +1
- Misses 77 78 +1
Continue to review full report at Codecov.
|
Contributor
|
Looks great, thanks! |
slycoder
approved these changes
Oct 16, 2018
chrono
added a commit
to chrono/onelogin-aws-cli
that referenced
this pull request
Oct 25, 2018
…ling * physera/master: Make sts client region aware (physera#134) Fix inconsistent profile names with different AWS partitions (physera#133) fix company typo (physera#129) Version bump Update pipfile.lock Add region option to command line and configuration file. (physera#127)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWS has multiple partitions e.g aws-cn or aws-us-gov which where previously not properly handled and cause not consistent
OneLoginprofile names.See in addition:
Related Issue
#132
Motivation and Context
Unified
OneLoginprofile names in ~/.aws/credentialsHow Has This Been Tested?
python setup.py nosetestsChinaAWSaccount withonelogin-aws-cliversion 0.1.15ChinaAWSaccount with updated version