Skip to content

auto_determine_ip_address is not a required value#123

Merged
slycoder merged 1 commit intophysera:masterfrom
drewsonne:patch-4
Jun 8, 2018
Merged

auto_determine_ip_address is not a required value#123
slycoder merged 1 commit intophysera:masterfrom
drewsonne:patch-4

Conversation

@drewsonne
Copy link
Contributor

If auto_determine_ip_address is not provided, an error No option 'auto_determine_ip_address' in section: 'defaults' is provided

Description

Added a default value for auto_determine_ip_address in the defaults section.

@codecov-io
Copy link

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files           6        6           
  Lines         328      328           
=======================================
  Hits          257      257           
  Misses         71       71
Impacted Files Coverage Δ
onelogin_aws_cli/configuration.py 92.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74aab3b...2b7d99d. Read the comment docs.

@slycoder slycoder merged commit 2195a78 into physera:master Jun 8, 2018
@teitei-tk teitei-tk mentioned this pull request Jun 20, 2018
chrono added a commit to chrono/onelogin-aws-cli that referenced this pull request Jul 3, 2018
…ling

* physera/master:
  v0.1.13 version bump (physera#124)
  auto_determine_ip_address is not a required value (physera#123)
@chrono
Copy link
Contributor

chrono commented Jul 10, 2018

this still crashes for me at

File "/usr/local/lib/python3.6/site-packages/onelogin_aws_cli/configuration.py", line 135, in auto_determine_ip_address
    "auto_determine_ip_address",
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/configparser.py", line 829, in getboolean
    raw=raw, vars=vars, fallback=fallback, **kwargs)
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/configparser.py", line 809, in _get_conv
    **kwargs)
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/configparser.py", line 803, in _get
    return conv(self.get(section, option, **kwargs))
  File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/configparser.py", line 792, in get
    raise NoOptionError(option, section)
configparser.NoOptionError: No option 'auto_determine_ip_address' in section: 'prod'

unless i add

fallback=self.config.DEFAULTS['auto_determine_ip_address']

@slycoder
Copy link
Contributor

Ah, I see what the issue is. It's cause we have an additional property for auto_determine_ip_address. Mind sending a PR for the fix and I'll push out a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants