auto_determine_ip_address is not a required value#123
Merged
slycoder merged 1 commit intophysera:masterfrom Jun 8, 2018
Merged
auto_determine_ip_address is not a required value#123slycoder merged 1 commit intophysera:masterfrom
slycoder merged 1 commit intophysera:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 6 6
Lines 328 328
=======================================
Hits 257 257
Misses 71 71
Continue to review full report at Codecov.
|
Merged
chrono
added a commit
to chrono/onelogin-aws-cli
that referenced
this pull request
Jul 3, 2018
…ling * physera/master: v0.1.13 version bump (physera#124) auto_determine_ip_address is not a required value (physera#123)
Contributor
|
this still crashes for me at unless i add |
Contributor
|
Ah, I see what the issue is. It's cause we have an additional property for auto_determine_ip_address. Mind sending a PR for the fix and I'll push out a new version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
auto_determine_ip_addressis not provided, an errorNo option 'auto_determine_ip_address' in section: 'defaults'is providedDescription
Added a default value for
auto_determine_ip_addressin the defaults section.