Merged
Conversation
cd-work
requested changes
Jun 21, 2022
cd-work
previously approved these changes
Jun 21, 2022
cd-work
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, Deno's
OpStateis borrowed immutably and access to the underlyingOnceFutureis synchronized via atokio::sync::Mutex.This may introduce contention on first access and a very minor overhead on subsequent accesses, when retrieving a reference to the
PhylumApiobject. API calls themselves can be executed entirely concurrently.Closes #444.
Checklist
closes #<issueNum>in description above)?Have you ensured that you have met the expected acceptance criteria?Have you updated all affected documentation?