Conversation
maxrake
requested changes
May 24, 2022
Contributor
maxrake
left a comment
maxrake
left a comment
There was a problem hiding this comment.
One question and one rustfmt adjustment to make CI happy.
maxrake
previously approved these changes
May 26, 2022
mathew-horner
previously approved these changes
May 26, 2022
cd-work
force-pushed
the
slasher
branch
2 times, most recently
from
ceefeee to
8997958
Compare
maxrake
reviewed
May 31, 2022
Contributor
maxrake
left a comment
maxrake
left a comment
There was a problem hiding this comment.
One remaining question to address before approval.
cd-work
force-pushed
the
slasher
branch
2 times, most recently
from
18c3c1c to
8596923
Compare
This reserves installation of extensions without slash, allowing us to later use this syntax to install extensions from the marketplace without risking users accidentally installing these remote extensions when trying to install local ones. Closes #356.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reserves installation of extensions without slash, allowing us to
later use this syntax to install extensions from the marketplace without
risking users accidentally installing these remote extensions when
trying to install local ones.
Closes #356.