Skip to content

salt_default_charset: add method for string salt with default charset #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

acidelk
Copy link

@acidelk acidelk commented Oct 8, 2018

I want calculate hash with default charset for salt.

@phxql phxql self-assigned this Oct 9, 2018
@phxql phxql self-requested a review October 9, 2018 06:56
@phxql
Copy link
Owner

phxql commented Oct 10, 2018

Hi,

thanks for the PR. I plan to deprecate the methods accepting a String in the future, as they are not as secure as the char[] methods. Therefore I won't add any new methods accepting a password as a String.

@phxql
Copy link
Owner

phxql commented Oct 10, 2018

But i see that there is a method with the signature

String hash(int iterations, int memory, int parallelism, char[] password, byte[] salt);

which uses the default UTF-8 encoding.

missing in Argon2Advanced.

Copy link
Owner

@phxql phxql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to deprecate all methods with accept a String password. Please do not add new ones.

@acidelk acidelk closed this Oct 10, 2018
@acidelk acidelk deleted the features/salt_default_charset branch November 17, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants