Dev other devices refactor #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically copied these changes from your commit to control24osc.py since procontrolosc had not been modded yet. as a result faders and pan pots are working now
automode is sending the wrong osc command to reaper. The "read" and "@" are inverted:
it should be /track/@/reaautomode/read (same for latch , trim etc...)
instead it is sending /track/read/reaautomode/@ to reaper, so consequently not working
Didn't figure out how to fix that yet.
Also is there a way to change the addresses for scribs and leds from 0xF0, 0x13, 0x01, .... to 0xF0, 0x13, 0x00, .... in procontrolosc.py instead of modifying ReaCommon.py ? I could only get them working by modding ReaCommon but that would mess up control24s