Skip to content

cfg-out csv feature #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2016
Merged

cfg-out csv feature #39

merged 1 commit into from
Sep 17, 2016
+28 −5

Conversation

alexbool
Copy link
Contributor

It pulls rustc-serialize which is not always desirable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.8% when pulling 6a6946f on alexbool:master into a32f0d2 on phsym:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 17, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.8% when pulling 6a6946f on alexbool:master into a32f0d2 on phsym:master.

@alexbool
cfg-out csv feature
33b8187 
It pulls `rustc-serialize` which is not always desirable
@coveralls
Copy link

coveralls commented Sep 17, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 95.855% when pulling 33b8187 on alexbool:master into a32f0d2 on phsym:master.

phsym
phsym approved these changes Sep 17, 2016
View reviewed changes
Copy link
Owner

@phsym phsym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! I've been thinking about doing this. Thanks a lot

@phsym phsym merged commit 7461ed0 into phsym:master Sep 17, 2016
@alexbool
Copy link
Contributor Author

Would be great to publish a release!

@phsym
Copy link
Owner

phsym commented Sep 17, 2016

Yes, I'm on my phone right now. I'll do the publish tomorrow

@phsym
Copy link
Owner

phsym commented Sep 18, 2016

Published in v0.6.5

@alexbool
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phsym phsym phsym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbool @coveralls @phsym