false positive with \Locale

[gsdevme]

I've noticed using the \Locale::getDisplayLanguage() and locale_get_display_language(). I switched to the functions thinking Id get around the headache of the false positive.

  34     Function locale_get_display_language invoked with 1 parameter, 2 required.
  39     Function locale_get_display_language invoked with 1 parameter, 2 required.

  35     Static method Locale::getDisplayLanguage() invoked with 1 parameter, 2 required.  
  40     Static method Locale::getDisplayLanguage() invoked with 1 parameter, 2 required.  

https://secure.php.net/manual/en/locale.getdisplaylanguage.php

[ondrejmirtes]

Hi,
this is an issue of reflection in PHP intl extension. I suggest you report it as a bug in their bug tracker.

Since this is a commonly used extension in PHP applications, I will add an exception to PHPStan core codebase for this defect, which I usually don't do with extensions, but I'll do it here.

[gsdevme]

Thank! I will submit a bug next time I get a chance.

…

Sent from my iPhone

On 3 Jun 2017, at 14:15, Ondřej Mirtes ***@***.***> wrote: Hi, this is an issue of reflection in PHP intl extension. I suggest you report it as a bug in their bug tracker. Since this is a commonly used extension in PHP applications, I will add an exception to PHPStan core codebase for this defect, which I usually don't do with extensions, but I'll do it here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ondrejmirtes]

Fixed: d51b1e2

If you like PHPStan and use it to find bugs in your projects, I'd love if you supported it on Patreon. I have many ideas how to make PHPStan even smarter and faster but doing it over evenings and weekends is not sustainable longterm. I'm trying to make developing open-source a viable livelihood alternative. Even a $1 a month helps, but the more you contribute, the closer I am to my goal to work on it fulltime :)