Drop PHP-Parser 2.x support

[Ocramius]

As I'm setting up (yet again) --prefer-lowest dependency testing, I'm encountering this nasty issue about PHP-Parser 2.x being installed, while my code is written for PHP 7.1.

Since PHPStan cannot work with PHP-Parser 2.x and a PHP 7.1 codebase, it would be best to finally drop support for it, and restrict dependency targets to PHP-Parser 3.x.

If support for PHPStan on PHP 5.x is required, then I strongly advise to make alternate releases: some for PHP 5.x (using PHP-Parser 2.x ONLY) and some for PHP 7.x (using PHP-Parser 3.x ONLY)

[JanTvrdik]

Alternative solutions I can think of

1. Use phpstan/phpstan-shim instead, but AFAIK this is still experimental

2. Add requirement for PHP-Parser 3.x or conflict with PHP-Parser 2.x to composer.json of your library.

[Ocramius]

Add requirement for PHP-Parser 3.x or conflict with PHP-Parser 2.x to composer.json of your library.

That is what I am currently doing, but the issue was opened exactly because requiring phpstan doesn't "just work", but needs these additional restrictions.

[ondrejmirtes]

Actually, the support for PHP-Parser 2.x is there because PHAR or shim repository didn't exist pre-0.7. It was the most common reason of conflicting dependencies, so I returned the support back in 0.5. It's not because of PHP 5.x, that was never supported. So now, when the PHAR can be downloaded and used, there's no reason to support PHP-Parser 2.x anymore. It will clean up the code and simplify the build a bit. I will remove it for 0.8 release.

[Ocramius]

👍

[Ocramius]

Just a note: this is the last issue for dropping php-parser from my dependencies in various libraries.

Upgrade dependencies often, upgrade them eagerly ;-)

[ondrejmirtes]

Solved: #354

This will be part of the upcoming 0.8 version. Next week is a couple of holidays here so I hope to get it out at the end of the week :)