Do not report private services in test container

composer.json

@@ -32,7 +32,7 @@
     "satooshi/php-coveralls": "^1.0",
     "slevomat/coding-standard": "^4.5.2",
     "phpstan/phpstan-phpunit": "^0.10",
-    "symfony/framework-bundle": "^3.0 || ^4.0"
+    "symfony/framework-bundle": "^4.1"
   },
   "conflict": {
     "symfony/framework-bundle": "<3.0"

src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php

@@ -43,7 +43,7 @@ public function processNode(Node $node, Scope $scope): array
 		$argType = $scope->getType($node->var);
 		$isControllerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Controller\Controller'))->isSuperTypeOf($argType);
 		$isContainerType = (new ObjectType('Symfony\Component\DependencyInjection\ContainerInterface'))->isSuperTypeOf($argType);
-		if (!$isControllerType->yes() && !$isContainerType->yes()) {
+		if ((!$isControllerType->yes() && !$isContainerType->yes()) || $this->isTestContainer($scope)) {
 			return [];
 		}
 
@@ -58,4 +58,22 @@ public function processNode(Node $node, Scope $scope): array
 		return [];
 	}
 
+	private function isTestContainer(Scope $scope): bool
+	{
+		$classReflection = $scope->getClassReflection();
+		if ($classReflection === null || !$classReflection->isSubclassOf('Symfony\Bundle\FrameworkBundle\Test\KernelTestCase')) {
+			return false;
+		}
+
+		$testContainer = $this->serviceMap->getService('test.service_container');
+		if ($testContainer === null) {
+			return false;
+		}
+		$class = $testContainer->getClass();
+
+		return $testContainer->isPublic()
+			&& $class !== null
+			&& (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf(new ObjectType($class))->yes();
+	}
+
 }

tests/Rules/Symfony/ContainerInterfacePrivateServiceRuleTest.php

@@ -28,4 +28,12 @@ public function testGetPrivateService(): void
 		);
 	}
 
+	public function testGetPrivateServiceOnTestContainer(): void
+	{
+		$this->analyse(
+			[__DIR__ . '/../../Symfony/data/KernelTestExample.php'],
+			[]
+		);
+	}
+
 }

tests/Symfony/ServiceMapTest.php

@@ -41,7 +41,7 @@ public function testGetServiceIdFromNode(): void
 		$broker = $this->createBroker();
 		$printer = new Standard();
 		$typeSpecifier = $this->createTypeSpecifier($printer, $broker);
-		$scope = new Scope($broker, $printer, $typeSpecifier, ScopeContext::create(''));
+		$scope = new Scope($this->createScopeFactory($broker, $typeSpecifier), $broker, $printer, $typeSpecifier, ScopeContext::create(''));
 
 		self::assertSame('foo', ServiceMap::getServiceIdFromNode(new String_('foo'), $scope));
 		self::assertSame('bar', ServiceMap::getServiceIdFromNode(new ClassConstFetch(new Name(ExampleController::class), 'BAR'), $scope));

tests/Symfony/data/KernelTestExample.php

@@ -0,0 +1,15 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Symfony;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+
+final class KernelTestExample extends KernelTestCase
+{
+
+	public function someTest(): void
+	{
+		self::$container->get('private');
+	}
+
+}

tests/Symfony/data/container.xml

@@ -9,5 +9,6 @@
     <service id="private" class="Foo" public="false"></service>
     <service id="synthetic" class="Foo" synthetic="true"></service>
     <service id="alias" class="Bar" alias="withClass"></service>
+    <service id="test.service_container" class="Symfony\Bundle\FrameworkBundle\Test\TestContainer"></service>
   </services>
 </container>