Skip to content

fix: Fix PHPStan errors on level 9#336

Closed
siketyan wants to merge 2 commits intophpstan:1.2.xfrom
siketyan:fix/phpstan-errors-lv9
Closed

fix: Fix PHPStan errors on level 9#336
siketyan wants to merge 2 commits intophpstan:1.2.xfrom
siketyan:fix/phpstan-errors-lv9

Conversation

@siketyan
Copy link
Copy Markdown
Contributor

Fixed some errors on PHPStan level 9.

As Is:

❯ vendor/bin/phpstan analyse src --level 9
Note: Using configuration file /Users/siketyan/.local/src/github.com/phpstan/phpstan-symfony/phpstan.neon.
 54/54 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------------ 
  Line   Symfony/Configuration.php                                                                                         
 ------ ------------------------------------------------------------------------------------------------------------------ 
  21     Method PHPStan\Symfony\Configuration::getContainerXmlPath() should return string|null but returns mixed.          
  26     Method PHPStan\Symfony\Configuration::hasConstantHassers() should return bool but returns mixed.                  
  31     Method PHPStan\Symfony\Configuration::getConsoleApplicationLoader() should return string|null but returns mixed.  
 ------ ------------------------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   Type/Symfony/ParameterDynamicReturnTypeExtension.php                                                                                                                 
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  166    Parameter #2 $value of method PHPStan\Type\Symfony\ParameterDynamicReturnTypeExtension::generalizeTypeFromValue() expects array|bool|float|int|string, mixed given.  
  177    Parameter #2 $value of method PHPStan\Type\Symfony\ParameterDynamicReturnTypeExtension::generalizeTypeFromValue() expects array|bool|float|int|string, mixed given.  
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 5 errors                                                                                                 
                                                                                                                        

To Be:

❯ vendor/bin/phpstan analyse src --level 9
Note: Using configuration file /Users/siketyan/.local/src/github.com/phpstan/phpstan-symfony/phpstan.neon.
 54/54 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors                                                                                                         

@VincentLanglet
Copy link
Copy Markdown
Contributor

Hi, thanks but the 1.x branch is not maintained anymore.

Also, I think level 8 might be enough atm.

@siketyan siketyan deleted the fix/phpstan-errors-lv9 branch April 22, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants