Skip to content

Configuration parameters to enable/disable rules #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

MartinMystikJonas
Copy link
Contributor

No description provided.

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to change some parameters names, parameters.strictRules.booleansInConditions is obvious, but parameters.strictRules.methods doesn't tell me anything, it sounds like with strict rules, you wouldn't be able to use methods at all ;)

@MartinMystikJonas
Copy link
Contributor Author

I'd also like to change some parameters names, parameters.strictRules.booleansInConditions is obvious, but parameters.strictRules.methods doesn't tell me anything, it sounds like with strict rules, you wouldn't be able to use methods at all ;)

Should I come with better names suggestions or do you have some in mind? I drafted it based on namespaces but I agree then it could be more descriptive.

@MartinMystikJonas
Copy link
Contributor Author

MartinMystikJonas commented Aug 7, 2022

I have updated configuration options names. Let me know if you want any of them changed.

parameters:
	strictRules:
		allRules: false
		booleansInConditions: false
		uselessCast: false
		requireParentConstructorCall: false
		disallowedConstructs: false
		overwriteVariablesWithLoop: false
		closureUsesThis: false
		matchingInheritedMethodNames: false
		numericOperandsInArithmeticOperators: false
		strictCalls: false
		switchConditionsMatchingType: false
		noVariableVariables: false

@ondrejmirtes
Copy link
Member

Perfect! Thank you very much.

@ondrejmirtes ondrejmirtes merged commit f120c3b into phpstan:1.3.x Aug 23, 2022
@ondrejmirtes
Copy link
Member

I've simplified the readme: 8019e79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants