Remove hardcoded TableErrorFormatter dependency in GithubErrorFormatter
#854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use the `GithubErrorFormatter` with any `ErrorFormatter`.
ruudk
force-pushed
the
GitHub-error-formatter-interface
branch
from
f6ad222 to
bed8fea
Compare
|
Thank you! |
williamdes
added a commit
to code-lts/cli-tools
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use the
GithubErrorFormatterwith anyErrorFormatter.In my project, I have a custom ErrorFormatter but I also want to use the
GitHubErrorFormatteron CI.