Fix PHPStorm inspection errors #4700
Merged
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jan 3, 2026
| continue; | ||
| } | ||
|
|
||
| foreach ($catchTypes as $catchTypeIndex => $catchTypeItem) { |
Contributor
Author
There was a problem hiding this comment.
unused variable $catchTypeIndex
Member
There was a problem hiding this comment.
Slevomat CS typically catches this, can you figure out why it doesn't in this case, maybe create a failign test for slevomat/coding-standard?
staabm
commented
Jan 3, 2026
| 'blocks', | ||
| ]; | ||
|
|
||
| foreach ($keys as $key) { |
staabm
commented
Jan 3, 2026
| $this->acceptUppercaseString($string); | ||
| $this->acceptUppercaseString($uppercaseString); | ||
| $this->acceptUppercaseString($numericString); | ||
| $this->acceptUppercaseString($nonEmptyLowercaseString); |
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jan 3, 2026
| continue; | ||
| } | ||
|
|
||
| foreach ($catchTypes as $catchTypeIndex => $catchTypeItem) { |
Member
There was a problem hiding this comment.
Slevomat CS typically catches this, can you figure out why it doesn't in this case, maybe create a failign test for slevomat/coding-standard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.