fix: explicitly use StreamSelectLoop for Pro download #4077
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
calebdw/push-vtwwlopurysq
branch
2 times, most recently
from
35afa96 to
7fa59cd
Compare
The Pro download kept failing in a Docker container when the `uv`
extension was enabled (which set the default global loop to the
`ExtUvLoop` instance) with the following error:
Connection to tls://fixer-download-api.phpstan.com:443 timed out after 5 seconds (ETIMEDOUT)
This can be fixed by explicitly using a `StreamSelectLoop` for the
Pro download, which is the same loop that's used everywhere else in the
codebase.
Note that we have to set this as the global loop because the `await()`
function no longer supports passing a loop as an argument.
calebdw
force-pushed
the
calebdw/push-vtwwlopurysq
branch
from
7fa59cd to
dc8117d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The Pro download kept failing in a Docker container when the
uvextension was enabled (which set the default global loop to the
ExtUvLoopinstance) with the following error:This can be fixed by explicitly using a
StreamSelectLoopfor thePro download, which is the same loop that's used everywhere else in the
codebase.
Note that we have to set this as the global loop because the
await()function no longer supports passing a loop as an argument.
Thanks!