Implement @pure-unless-callable-impure #3482
Conversation
src/PhpDoc/PhpDocNodeResolver.php
Outdated
| public function resolveParamPureUnlessCallableIsImpure(PhpDocNode $phpDocNode): array | ||
| { | ||
| $parameters = []; | ||
| // TODO: implement phpstan/phpdoc-parser |
There was a problem hiding this comment.
Will be replaced by phpstan/phpdoc-parser#253
| @@ -22,6 +22,7 @@ public function __construct( | |||
| private ?Type $outType, | |||
| private TrinaryLogic $immediatelyInvokedCallable, | |||
| private ?Type $closureThisType, | |||
| private bool $pureUnlessCallableIsImpureParameter = false, | |||
There was a problem hiding this comment.
WIP. = false will be removed.
|
Just updated phpdoc-parser here so you can use that. |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
4 times, most recently
from
eddd22a
to
f207c72
Compare
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
f207c72
to
8c756cc
Compare
|
@zonuexe any plans to move this forward? |
|
@staabm Hi, I know this branch is important but it was blocked due to my motivation. I'm going to rebase it on 2.0.x and do the necessary work. If I miss it tonight, I won't be able to start the rest of the work until next week, so it would be quicker for you to take over then. |
|
I don't want to put pressure on you. It was not clear to me whether you stopped working on it or not. I am totally fine if this takes a bit more time - thank you |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
8c756cc
to
389c7f0
Compare
|
No problem, this is a very interesting subject for me too, so I'm happy to work on it because I realized that there are other people who are interested in it. More importantly, I'm always helped by your hard work. |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
2 times, most recently
from
c89f485
to
b0d5146
Compare
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
b0d5146
to
2146ae0
Compare
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
2146ae0
to
1cc1fad
Compare
This PR is still a work in progress, no tests or rules have been added yet.
refs #3106, phpstan/phpstan#11100 and phpstan/phpstan#11710
related issue phpstan/phpdoc-parser#253