Extract ConstructorsHelper

[herndlm]

... and make use of it also in ReadOnlyByPhpDocPropertyAssignRule and ReadOnlyPropertyAssignRule.

Closes phpstan/phpstan#6612

[ondrejmirtes]

Does it solve phpstan/phpstan#6612 ? :)

[herndlm]

Does it solve phpstan/phpstan#6612 ? :)

not yet, I thought of another PR. but can do that here too for sure :)

[ondrejmirtes]

Yeah, sure, this makes sense as a logical first step, you can add a 2nd commit that uses the new helper in a new place :)

[ondrejmirtes]

Perfect, thank you!

BTW About the @readonly PHPDoc feature - I realized we should do one more thing - if there's @immutable, @phpstan-immutable, or @psalm-immutable above the class, isReadOnlyByPhpDoc for a property should also return true.

[herndlm]

BTW About the @readonly PHPDoc feature - I realized we should do one more thing - if there's @immutable, @phpstan-immutable, or @psalm-immutable above the class, isReadOnlyByPhpDoc for a property should also return true.

That was basically my follow-up idea! (I think I hinted it in the original PR description) ;) Then I found https://wiki.php.net/rfc/readonly_classes though and wanted to ask if this (@readonly on the class) should be supported too in the same way maybe? I need to read that in detail again, but I guess more rule adaptions or new rules are needed for that native readonly feature later for PHP 8.2. But different thing now, I guess.

[ondrejmirtes]

That RFC is unrelated to what we need to do here.

I'll work on 8.2 support after feature freeze. And my guess is that not a single line of code will need to be changed in PHPStan, only in BetterReflection 😊

[herndlm]

OK, I'll add immutable support later, should be super-easy now.