Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant array comparison for optional keys #1324

Merged
merged 5 commits into from
May 18, 2022
Merged

Fix constant array comparison for optional keys #1324

merged 5 commits into from
May 18, 2022

Commits on May 18, 2022

  1. Fix constant array comparison for optional keys

    @rvanvelzen
    rvanvelzen committed May 18, 2022
    Configuration menu
    Copy the full SHA
    78b2648 View commit details
    Browse the repository at this point in the history

  2. Add additional tests covering always-false cases with optional keys

    @rvanvelzen
    rvanvelzen committed May 18, 2022
    Configuration menu
    Copy the full SHA
    dddd311 View commit details
    Browse the repository at this point in the history

  3. Fix non-constant result

    @rvanvelzen
    rvanvelzen committed May 18, 2022
    Configuration menu
    Copy the full SHA
    630df0e View commit details
    Browse the repository at this point in the history

  4. Improve constant array comparison algorithm and fix == checks

    @rvanvelzen
    rvanvelzen committed May 18, 2022
    Configuration menu
    Copy the full SHA
    c570bc7 View commit details
    Browse the repository at this point in the history

  5. Simplify

    @rvanvelzen
    rvanvelzen committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a5db235 View commit details
    Browse the repository at this point in the history