Prevent redundant messages about missing iterable types in conditional target/subject #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ondrejmirtes the same can probably be said about "Generic type X in PHPDoc tag @return does not specify all template types of class Y: ..."? |
rvanvelzen
commented
May 15, 2022
Comment on lines
+77
to
+85
| if ($type instanceof ConditionalType || $type instanceof ConditionalTypeForParameter) { | ||
| $iterablesWithMissingValueTypehint = array_merge( | ||
| $iterablesWithMissingValueTypehint, | ||
| $this->getIterableTypesWithMissingValueTypehint($type->getIf()), | ||
| $this->getIterableTypesWithMissingValueTypehint($type->getElse()), | ||
| ); | ||
|
|
||
| return $type; | ||
| } |
There was a problem hiding this comment.
Not overly excited by this. An alternative would be to get the resolved type, but that might skip over types that disappear after normalization.
|
Thank you! @rvanvelzen The same logic should be applied in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#7215