use conditional return type for is_a() via stub #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
May 13, 2022
| @@ -1,5 +1,13 @@ | |||
| <?php | |||
|
|
|||
| /** | |||
| * @param mixed $object_or_class | |||
There was a problem hiding this comment.
couldn't we even use a conditional parameter type here?
Suggested change
| * @param mixed $object_or_class | |
| * @param ($allow_string is false ? object : object|class-string) $object_or_class |
There was a problem hiding this comment.
Try it after this PR is merged :)
There was a problem hiding this comment.
oh my.. now I get what you was telling me in #1306 (comment) .. will send a 2nd PR ..
staabm
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#4371 (comment)