Do not report nonexistent paths in ignoreErrors if `reportUnmatchedIg…

…noredErrors: false`
phpstan · Aug 8, 2024 · b7fe990 · b7fe990
1 parent 6ee5c22
commit b7fe990
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 2 deletions.
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
@@ -247,6 +247,10 @@ jobs:
               cp -r tmp-node-modules node_modules
               OUTPUT=$(../../bin/phpstan analyse -c ignoreNonexistentExcludePath.neon)
               echo "$OUTPUT"
+          - script: |
+              cd e2e/bad-exclude-paths
+              OUTPUT=$(../../bin/phpstan analyse -c ignoreReportUnmatchedFalse.neon)
+              echo "$OUTPUT"
 
     steps:
       - name: "Checkout"

diff --git a/e2e/bad-exclude-paths/ignoreReportUnmatchedFalse.neon b/e2e/bad-exclude-paths/ignoreReportUnmatchedFalse.neon
@@ -0,0 +1,12 @@
+includes:
+	- ../../conf/bleedingEdge.neon
+
+parameters:
+	level: 8
+	paths:
+		- src
+	reportUnmatchedIgnoredErrors: false
+	ignoreErrors:
+		-
+			message: '#aaa#'
+			path: tests
diff --git a/src/Command/CommandHelper.php b/src/Command/CommandHelper.php
@@ -355,6 +355,11 @@ public static function begin(
 				$errorOutput->writeLineFormatted($error);
 				$errorOutput->writeLineFormatted('');
 			}
+
+			$errorOutput->writeLineFormatted('To ignore non-existent paths in ignoreErrors,');
+			$errorOutput->writeLineFormatted('set <fg=cyan>reportUnmatchedIgnoredErrors: false</> in your configuration file.');
+			$errorOutput->writeLineFormatted('');
+
 			throw new InceptionNotSuccessfulException();
 		} catch (InvalidExcludePathsException $e) {
 			$errorOutput->writeLineFormatted(sprintf('<error>Invalid %s in excludePaths:</error>', count($e->getErrors()) === 1 ? 'entry' : 'entries'));

diff --git a/src/DependencyInjection/NeonAdapter.php b/src/DependencyInjection/NeonAdapter.php
@@ -31,7 +31,7 @@
 class NeonAdapter implements Adapter
 {
 
-	public const CACHE_KEY = 'v27-optional-path';
+	public const CACHE_KEY = 'v28-ignore-errors';
 
 	private const PREVENT_MERGING_SUFFIX = '!';
 

diff --git a/src/DependencyInjection/ValidateIgnoredErrorsExtension.php b/src/DependencyInjection/ValidateIgnoredErrorsExtension.php
@@ -136,7 +136,9 @@ public function getRegistry(): OperatorTypeSpecifyingExtensionRegistry
 			}
 		}
 
-		if ($noImplicitWildcard) {
+		$reportUnmatched = (bool) $builder->parameters['reportUnmatchedIgnoredErrors'];
+
+		if ($noImplicitWildcard && $reportUnmatched) {
 			foreach ($ignoreErrors as $ignoreError) {
 				if (!is_array($ignoreError)) {
 					continue;