Component::lookup nullable when $need=false #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I will review this once the build succeeds. |
adaamz
force-pushed
the
patch-1
branch
3 times, most recently
from
caa7b74 to
194171d
Compare
|
@ondrejmirtes Build is green 🎉 |
|
This is weird - where's the code? 😊 |
|
@ondrejmirtes Code is here 🎉 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nette\ComponentModel\Component:lookup return type is based on second parameter ($need). When $need is false then return type is
IComponent|null.btw. I would to add feature to directly know return type based on first parameter
$class. Is it possible to get it now? I know the case whenMyComponentClass::classis passed... but when it is some function call (for which phpstan has extension for example), is it possible?