issue with findOneByX

[dmaicher]

In some repositories I have some custom functions named like findOneByX

Example:

class ReviewRepository
{
    public function findOneByReviewConfigAndId(...) { }
}

Seems that is not working properly:

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   someClass.php                                                                                                                                             
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  209    Call to method X\ReviewRepository<X\Entity\Review>::findOneByReviewConfigAndId() - entity X\Entity\Review does not have a field named  
         $reviewConfigAndId.                                                                                                                                                                         
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

[ondrejmirtes]

I see - real method name clashes with the magic method convention.

[luxemate]

@ondrejmirtes Today I ran into similar problem. Having repo like

class FooRepository
{
    public function findByDoesNotMatter(): ?Foo { }
}

results in PHPStan thinking it's an array because of findBy, not findOneBy.

 ------ ------------------------------------------------------------------------------------------ 
  Line   FooRepository.php  
 ------ ------------------------------------------------------------------------------------------ 
  36     Cannot call method someMethod() on array<int, Foo>.                                         
 ------ ------------------------------------------------------------------------------------------ 

Plus, real method clashes with the magic one.

[ondrejmirtes]

I agree, will fix it. BTW I think you should adhere to the same convention and rename this method to findOneByDoesNotMatter because otherwise you're causing confusion for your developers :D

[luxemate]

Yeah, that's what I did. Luckily, that was the only method that was out of convention.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.