Skip to content

Add generic support to @method definitions #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Add generic support to @method definitions #160

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93e9088
Add generic support to `@method` definitions
tyabu12 Nov 1, 2022
6e9c776
Avoid BC break and reuse TemplateTagValueNode
tyabu12 Nov 1, 2022
e661949
Fix PHP 7.2 lint
tyabu12 Nov 1, 2022
ba315ab
Fix PHP 7.2 lint again
tyabu12 Nov 1, 2022
cbcd76b
Fix PHP 7.2 lint again 2
tyabu12 Nov 1, 2022
6838eed
Fix coding standard errors
tyabu12 Nov 1, 2022
96d3a2f
Reuse parseTemplateTagValue
tyabu12 Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix coding standard errors
  • Loading branch information
@tyabu12
tyabu12 committed Nov 1, 2022
commit 6838eed6c9d2b8107c313163a27b871147cc5d0c
1 change: 1 addition & 0 deletions src/Ast/PhpDoc/MethodTagValueNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use PHPStan\PhpDocParser\Ast\NodeAttributes;
use PHPStan\PhpDocParser\Ast\Type\TypeNode;
use function count;
use function implode;

class MethodTagValueNode implements PhpDocTagValueNode
Expand Down
8 changes: 4 additions & 4 deletions tests/PHPStan/Parser/PhpDocParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2242,8 +2242,8 @@ public function provideMethodTagsData(): Iterator
),
]
)
)
])
),
]),
];

yield [
Expand Down Expand Up @@ -2286,8 +2286,8 @@ public function provideMethodTagsData(): Iterator
new TemplateTagValueNode('T3', new IdentifierTypeNode('Baz'), ''),
]
)
)
])
),
]),
];
}

Expand Down